fix: initialization for CADENCE_WEB_PORT in dev#1230
Merged
Assem-Uber merged 2 commits intocadence-workflow:masterfrom Apr 7, 2026
Merged
fix: initialization for CADENCE_WEB_PORT in dev#1230Assem-Uber merged 2 commits intocadence-workflow:masterfrom
Assem-Uber merged 2 commits intocadence-workflow:masterfrom
Conversation
Assem-Uber
changed the title
Code Review ✅ ApprovedInitializes CADENCE_WEB_PORT environment variable for development environment. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
| }, | ||
| "scripts": { | ||
| "dev": "next dev -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0} | pino-pretty --messageKey message", | ||
| "dev": "CADENCE_WEB_PORT=${CADENCE_WEB_PORT:-8088} next dev -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0} | pino-pretty --messageKey message", |
Member
There was a problem hiding this comment.
Is this still necessary if we pass the env variable?
Contributor
Author
There was a problem hiding this comment.
Yes, this is the only way nextJs would start the server on that port
adhityamamallan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix initialization of
CADENCE_WEB_PORTenv variable to unify the value of the port in the dynamic code value & the value that dev server starts with. The fix is not needed for production docker images as the environment variable is initialized correctly.Details
The web server used to start on port
8088while accessing the value in dynamic config was3000. Setting the environment variable before running the server makes sure that both starting port and dynamic config value is8088Testing